fix: block out of order migrations in migrations tool #7693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcrfxia
approved these changes
Jun 22, 2021
| if (version < minimumVersion) { | ||
| throw new MigrationException( | ||
| "Version must be newer than the last version migrated. Last version migrated was " | ||
| + (minimumVersion - 1)); |
There was a problem hiding this comment.
nit: it's not great that apply() gets the latest migrated version, transforms that into minimumVersion to pass to loadMigrationsToApply(), and then loadMigrationsToApply() undoes the transformation again in this error message. Maybe we can have apply() directly pass the last migrated version and move the logic for computing minimumVersion into loadMigrationsToApply() instead? Less coupling between the two methods that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a check to make sure the version specified by
apply -v <number>is greater than the last applied version.Testing done
Unit and integration tests
Reviewer checklist