Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better error message on illegal arithmetic with NULL values #7554

Merged
merged 13 commits into from
May 20, 2021
Merged

fix: better error message on illegal arithmetic with NULL values #7554

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
86d9a64
fix: better error message on illegal arithmetic
May 19, 2021
ee80372
fix checkstyle
May 19, 2021
314f449
modify existing unit tests
May 19, 2021
adb39a4
add more unit tests
May 19, 2021
6b862cd
add rqtt
May 19, 2021
e144574
more unit test
May 19, 2021
726bbb3
move tests from RQTT to QTT
May 19, 2021
84bf7e9
refactor
May 19, 2021
7523e1e
interpreter compiler error message parity
May 20, 2021
4c00399
change QVT
May 20, 2021
2412bcd
remove QTT
May 20, 2021
8e97034
add RQTT
May 20, 2021
d7c3833
minor test change to match new error message
May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move tests from RQTT to QTT
  • Loading branch information
Chittaranjan Prasad committed May 19, 2021
commit 726bbb3d68cdd1b8e8d6e5e5221457282064b7d5
60 changes: 60 additions & 0 deletions ksqldb-functional-tests/src/test/resources/query-validation-tests/math.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,66 @@
}
]
}
},
{
"name": "NULL Arithmetic Behavior - INTEGER addition",
"statements": [
"CREATE STREAM INPUT (ID INT) WITH (kafka_topic='test_topic', value_format='JSON');",
"SELECT 1 + NULL FROM INPUT EMIT CHANGES;"
],
"expectedError": {
"type": "io.confluent.ksql.rest.entity.KsqlErrorMessage",
"message": "Error processing expression: (1 + null). Arithmetic on types INTEGER and null are not supported.",
"status": 400
}
},
{
"name": "NULL Arithmetic Behavior - MAP addition",
"statements": [
"CREATE STREAM INPUT (ID INT) WITH (kafka_topic='test_topic', value_format='JSON');",
"SELECT MAP(1 := 'cat') + NULL FROM INPUT EMIT CHANGES;"
],
"expectedError": {
"type": "io.confluent.ksql.rest.entity.KsqlErrorMessage",
"message": "Error processing expression: (MAP(1:='cat') + null). Arithmetic on types MAP<INTEGER, STRING> and null are not supported.",
"status": 400
}
},
{
"name": "NULL Arithmetic Behavior - ARRAY addition",
"statements": [
"CREATE STREAM INPUT (ID INT) WITH (kafka_topic='test_topic', value_format='JSON');",
"SELECT Array[1,2,3] + NULL FROM INPUT EMIT CHANGES;"
],
"expectedError": {
"type": "io.confluent.ksql.rest.entity.KsqlErrorMessage",
"message": "Error processing expression: (ARRAY[1, 2, 3] + null). Arithmetic on types ARRAY<INTEGER> and null are not supported.",
"status": 400
}
},
{
"name": "NULL Arithmetic Behavior - DECIMAL division",
"statements": [
"CREATE STREAM INPUT (ID INT) WITH (kafka_topic='test_topic', value_format='JSON');",
"SELECT 5.0 / NULL FROM INPUT EMIT CHANGES;"
],
"expectedError": {
"type": "io.confluent.ksql.rest.entity.KsqlErrorMessage",
"message": "Error processing expression: (5.0 / null). Arithmetic on types DECIMAL(2, 1) and null are not supported.",
"status": 400
}
},
{
"name": "NULL Arithmetic Behavior - NULL NULL multiplication",
"statements": [
"CREATE STREAM INPUT (ID INT) WITH (kafka_topic='test_topic', value_format='JSON');",
"SELECT NULL * NULL FROM INPUT EMIT CHANGES;"
],
"expectedError": {
"type": "io.confluent.ksql.rest.entity.KsqlErrorMessage",
"message": "Error processing expression: (null * null). Arithmetic on types null and null are not supported.",
"status": 400
}
}
]
}
60 changes: 0 additions & 60 deletions ksqldb-functional-tests/src/test/resources/rest-query-validation-tests/push-queries.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,66 +927,6 @@
{"finalMessage":"Limit Reached"}
]}
]
},
{
"name": "NULL Arithmetic Behavior - INTEGER addition",
"statements": [
"CREATE STREAM INPUT (ID INT) WITH (kafka_topic='test_topic', value_format='JSON');",
"SELECT 1 + NULL FROM INPUT EMIT CHANGES;"
],
"expectedError": {
"type": "io.confluent.ksql.rest.entity.KsqlErrorMessage",
"message": "Error processing expression: (1 + null). Arithmetic on types INTEGER and null are not supported.",
"status": 400
}
},
{
"name": "NULL Arithmetic Behavior - MAP addition",
"statements": [
"CREATE STREAM INPUT (ID INT) WITH (kafka_topic='test_topic', value_format='JSON');",
"SELECT MAP(1 := 'cat') + NULL FROM INPUT EMIT CHANGES;"
],
"expectedError": {
"type": "io.confluent.ksql.rest.entity.KsqlErrorMessage",
"message": "Error processing expression: (MAP(1:='cat') + null). Arithmetic on types MAP<INTEGER, STRING> and null are not supported.",
"status": 400
}
},
{
"name": "NULL Arithmetic Behavior - ARRAY addition",
"statements": [
"CREATE STREAM INPUT (ID INT) WITH (kafka_topic='test_topic', value_format='JSON');",
"SELECT Array[1,2,3] + NULL FROM INPUT EMIT CHANGES;"
],
"expectedError": {
"type": "io.confluent.ksql.rest.entity.KsqlErrorMessage",
"message": "Error processing expression: (ARRAY[1, 2, 3] + null). Arithmetic on types ARRAY<INTEGER> and null are not supported.",
"status": 400
}
},
{
"name": "NULL Arithmetic Behavior - DECIMAL division",
"statements": [
"CREATE STREAM INPUT (ID INT) WITH (kafka_topic='test_topic', value_format='JSON');",
"SELECT 5.0 / NULL FROM INPUT EMIT CHANGES;"
],
"expectedError": {
"type": "io.confluent.ksql.rest.entity.KsqlErrorMessage",
"message": "Error processing expression: (5.0 / null). Arithmetic on types DECIMAL(2, 1) and null are not supported.",
"status": 400
}
},
{
"name": "NULL Arithmetic Behavior - NULL NULL multiplication",
"statements": [
"CREATE STREAM INPUT (ID INT) WITH (kafka_topic='test_topic', value_format='JSON');",
"SELECT NULL * NULL FROM INPUT EMIT CHANGES;"
],
"expectedError": {
"type": "io.confluent.ksql.rest.entity.KsqlErrorMessage",
"message": "Error processing expression: (null * null). Arithmetic on types null and null are not supported.",
"status": 400
}
}
]
}