-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: better error message on illegal arithmetic with NULL values #7554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A few nits before merging
ksqldb-functional-tests/src/test/resources/rest-query-validation-tests/push-queries.json
Show resolved
Hide resolved
ksqldb-common/src/main/java/io/confluent/ksql/schema/Operator.java
Outdated
Show resolved
Hide resolved
ksqldb-common/src/main/java/io/confluent/ksql/schema/Operator.java
Outdated
Show resolved
Hide resolved
ksqldb-execution/src/main/java/io/confluent/ksql/execution/util/ExpressionTypeManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's outside the scope of this PR, but might be good to have tests for other expression types, e.g. COL > 1 AND NULL
where we have a NULL literal used in other areas. I know this is a lot of surface area potentially.
ksqldb-common/src/main/java/io/confluent/ksql/schema/Operator.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/test/java/io/confluent/ksql/execution/ExpressionEvaluatorParityTest.java
Outdated
Show resolved
Hide resolved
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cprasad1!
Description
This PR makes the error handling better when we try to do arithmetic with
NULL
.Testing done
Reviewer checklist