Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added script to export antlr tokens to use in frontend editor #7118

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

tolgadur
Copy link
Contributor

@tolgadur tolgadur commented Mar 1, 2021

Jira: KCI-170

Description

Query editor in the UI was missing a lot of ANTLR tokens in the highlighting and autocomplete such as LIST or DESCRIBE. This function is extracting the ANTLR tokens and is called by a script in the frontend to update the ui automatically.

Testing done

I wrote a unit test for the method to ensure that the tokens are correctly extracted.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@tolgadur tolgadur requested a review from swist March 1, 2021 17:05
@tolgadur tolgadur requested a review from a team as a code owner March 1, 2021 17:05
@ghost
Copy link

ghost commented Mar 1, 2021

It looks like @tolgadur hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@tolgadur
Copy link
Contributor Author

tolgadur commented Mar 1, 2021

[clabot:check]

@ghost
Copy link

ghost commented Mar 1, 2021

@confluentinc It looks like @tolgadur just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@tolgadur tolgadur merged commit 7e1c180 into confluentinc:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants