Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removes orphaned topics from transient queries #6714

Merged
merged 10 commits into from
Dec 10, 2020
Merged

fix: Removes orphaned topics from transient queries #6714

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a4c72e5
fix: Removes orphaned topics from transient queries
AlanConfluent Dec 2, 2020
ac7fa9e
Catch exception while listing topic names
AlanConfluent Dec 2, 2020
00285af
Writes transient queries to disk so they can be cleaned up
AlanConfluent Dec 8, 2020
0c572b5
Lint
AlanConfluent Dec 8, 2020
c4598b9
Lint again
AlanConfluent Dec 8, 2020
a9a671b
Fix test
AlanConfluent Dec 8, 2020
92cb462
Apply suggestions from code review
AlanConfluent Dec 9, 2020
4c89d54
Apply suggestions from code review
AlanConfluent Dec 9, 2020
1f73ce5
Feedback
AlanConfluent Dec 9, 2020
484484a
Removes redundant type field
AlanConfluent Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Almog Gavra <almog@confluent.io>
  • Loading branch information
@AlanConfluent @agavra
AlanConfluent and agavra committed Dec 9, 2020
commit 4c89d54c78e11a59a640dd7dbb29de933102bba9
2 changes: 1 addition & 1 deletion ksqldb-rest-app/src/main/java/io/confluent/ksql/rest/server/LocalCommands.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public void write(final TransientQueryMetadata queryMetadata) {
} catch (IOException e) {
// Just log an error since not catching it would likely cause more cleanup work than this
// aims to fix.
LOG.error("Failed to write local command", e);
LOG.error("Failed to write local command for transient query:" + queryMetadata.getQueryApplicationId(), e);
}
}

Expand Down