refactor: re-use CreateSourceFactory to create streams/tables for CREATE_AS statements #6594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
approved these changes
Nov 12, 2020
ableegoldman
added a commit
to ableegoldman/ksql
that referenced
this pull request
Nov 17, 2020
… for CREATE_AS statements (confluentinc#6594)" This reverts commit 1e46ff8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, the
CreateStreamCommandcreation code was redundant in theEngineExecutor.maybeCreateSinkDdland theCreateSourceFactory. This PR moves the code from theEngineExecutorto theCreateSourceFactoryto re-use part of the code there.Right now, the PR doesn't re-use code. But it will be needed by #6073 so it checks if the stream or table command exists before creating it.
Testing done
Added unit tests
Reviewer checklist