Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add an endpoint for returning the query limit configuration #6353

Merged
merged 5 commits into from
Oct 12, 2020
Merged

feat: Add an endpoint for returning the query limit configuration #6353

merged 5 commits into from
Oct 12, 2020

Conversation

jzaralim
Copy link
Contributor

@jzaralim jzaralim commented Oct 2, 2020

Description

This PR adds a new ksqlDB API endpoint for requesting specific configs. Currently, only the persistent query limit can be requested.

Fixes #6275

Testing done

Manually tested with:

 curl "http://localhost:8088/v1/configs"
{"configs":{"ksql.query.persistent.active.limit":20}}

 curl "http://localhost:8088/v1/configs?name=foo"
{"configs":{}}

 curl "http://localhost:8088/v1/configs?name=ksql.query.persistent.active.limit&name=foo"
{"configs":{"ksql.query.persistent.active.limit":20}}

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@jzaralim jzaralim requested a review from a team as a code owner October 2, 2020 21:37
spena
spena approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@spena spena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ksqldb-rest-model/src/main/java/io/confluent/ksql/rest/entity/ConfigResponse.java Outdated Show resolved Hide resolved
@spena spena requested a review from a team October 6, 2020 21:50
agavra
agavra approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think there's probably corresponding documentation updates that need to be made though... 😉

ksqldb-rest-app/src/main/java/io/confluent/ksql/rest/server/resources/ConfigResource.java Outdated Show resolved Hide resolved
ksqldb-rest-app/src/test/java/io/confluent/ksql/rest/integration/RestApiTest.java Show resolved Hide resolved
JimGalasyn
JimGalasyn approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jzaralim jzaralim merged commit 84d202d into confluentinc:master Oct 12, 2020
@jzaralim jzaralim deleted the config-endpoint branch October 12, 2020 20:17
spena added a commit that referenced this pull request Oct 20, 2020
@spena
Revert "feat: Add an endpoint for returning the query limit configura…
1731f29 
…tion (#6353)"

The alternative is to use `show properties`, which display all server properties
with defaults and passwor obfuscated.

This reverts commit 84d202d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spena spena spena approved these changes

@agavra agavra agavra approved these changes

@JimGalasyn JimGalasyn JimGalasyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add a ksqlDB API for returning the query limit configuration (and other configs)
4 participants
@jzaralim @agavra @spena @JimGalasyn