-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SEC-1034: log4j migration to confluent repackaged version #5783
Conversation
@confluentinc It looks like @niteshmor just signed our Contributor License Agreement. 👍 Always at your service, clabot |
Note that there is a cyclic dependency here. There's a PR in common which needs to get merged first. Once that PR gets merged, the 6.0.x + master branches in this repository will start seeing a failure. This PR will be the fix for those failures, and it should be merged once common has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
common/pom.xml
excludes default log4j as a transitive dependency, and the repackaged version must be explicitly added.Ref: confluentinc/common#270