feat: support WINDOWEND in WHERE of pull queries #5680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../java/io/confluent/ksql/execution/streams/materialization/ks/KsMaterializedSessionTable.java
Outdated
Show resolved
Hide resolved
| @@ -61,28 +63,35 @@ | |||
| private List<WindowedRow> findSession( | |||
| final ReadOnlySessionStore<Struct, GenericRow> store, | |||
| final Struct key, | |||
| final Range<Instant> windowStart | |||
| final Range<Instant> windowStart, | |||
| final Range<Instant> windowEnd | |||
| ) { | |||
| try (KeyValueIterator<Windowed<Struct>, GenericRow> it = store.fetch(key)) { | |||
There was a problem hiding this comment.
Just for my own knowledge, why don't we fetch from the store using the same bounds as in KsMaterializedWindowTable.java. Is it because the window sizes are not uniform in size and therefore we don't know exactly where to stop if all we know is the window start range? If they provide a window end range now, it seems like we could provide bounds to the store lookup (and could use Long.MAX_VALUE anyway).
There was a problem hiding this comment.
The Streams API for session tables is different. There is no fetch(key, lower, upper) method.
|
I'm assuming you were meaning to approve this @AlanConfluent and merging. Any other issues just let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #5666
Pull queries can now reference WINDOWEND in their WHERE clause, (assuming the source is windowed):
Testing done
usual
Reviewer checklist