feat: turn on snappy compression for produced data #5495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves space on the Kafka brokers and across the wire. The is a slight hit to CPU load. However, its rare that turning compression on reduces throughput: almost universally it increases it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets all Kafka producers used by ksqlDB to use snappy compression to reduce the size across the wire and on-disk in the Kafka brokers. There is a slight hit to CPU load. However, its rare that turning compression on reduces throughput: almost universally it increases it.
Testing done
Ensures this was flowing through to the producers
Reviewer checklist