feat: support custom column widths in cli #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@confluentinc It looks like @colinhicks just signed our Contributor License Agreement. 👍 Always at your service, clabot |
agavra
approved these changes
Feb 25, 2020
| @@ -27,6 +27,7 @@ | |||
| public class CliConfig extends AbstractConfig { | |||
|
|
|||
| public static final String WRAP_CONFIG = "WRAP"; | |||
| public static final String COLUMN_WIDTH_CONFIG = "COLUMN-WIDTH"; | |||
There was a problem hiding this comment.
for what it's worth, postgres does:
postgres=# \pset columns 20
Target width is 20.
I think COLUMN-WIDTH is easier to understand, but just something to note.
colinhicks
added a commit
that referenced
this pull request
Feb 27, 2020
Allow column width to be explicitly specified in tabular cli output, e.g.: ksql> SET CLI COLUMN-WIDTH 10 Given a customized value, subsequent renderings of output use the setting. The default behavior, in which column width is determined based on the terminal width and column count, can be re-enabled using: ksql> SET CLI COLUMN-WIDTH 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow column width to be explicitly specified in tabular cli output. By default, column width is determined based on the terminal width and the number of columns. With these changes, the width of each column may be optionally overridden:
Given a customized value, subsequent renderings of output use the setting:
The default behavior can be re-enabled using:
Testing done
Existing and added unit tests
Built Docker image and smoke tested
resolves #4141
Reviewer checklist