fix: fix NPE in CLI if not username supplied #4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NPE when running the CLI with no arguments. Was throwing NPE on line:
```java
if (!options.getUserName().isEmpty() && !options.isPasswordSet()) {
```
in Ksql.java, as `options.getUserName()` was returning `null`.
Refactored so that username and password are never null, only empty.
Also refactored so that server will default to `http://localhost:8088`, even if other params are supplied. Previously, it only defaulted to this if no params supplied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes NPE when running the CLI with no arguments. Was throwing NPE on line:
in Ksql.java, as
options.getUserName()was returningnull.Refactored so that username and password are never null, only empty.
Also refactored so that server will default to
http://localhost:8088, even if other params are supplied. Previously, it only defaulted to this if no params supplied.Testing done
Added tests and manual
Reviewer checklist