fix: add ksql-test-runner deps to ksql package lib #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spena
commented
Jan 10, 2020
| @@ -83,7 +83,6 @@ | |||
| <excludes> | |||
| <exclude>io.confluent:rest-utils</exclude> | |||
| <exclude>io.confluent:common-config</exclude> | |||
| <exclude>io.confluent:common-utils</exclude> | |||
There was a problem hiding this comment.
common-utils is also required for running the test runner from the package.
big-andy-coates
approved these changes
Jan 16, 2020
spena
added a commit
to spena/ksql
that referenced
this pull request
Feb 3, 2020
2 tasks
spena
added a commit
that referenced
this pull request
Feb 3, 2020
spena
added a commit
that referenced
this pull request
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3387
Adds the necessary dependencies on the KSQL package so ksql-test-runner can run without issues.
Testing done
Executed a ksql-test-runner test from withing the
ksql-package-5.5.0-SNAPSHOT-package/bindirectory. The test passed.Reviewer checklist