fix: support NULL return values from CASE statements #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the processing of `CASE` statements so that both `THEN` and the default return types can be `NULL`.
At least one branch must be non-null so that KSQL can determine the result type of the statement.
All non-null branches must have the same result schema, i.e. we don't (yet) do any implicit casting of numeric types.
The commit also improves some error messages by using KSQL types rather than connect schema types so that error messages use, for example, `BIGINT` rather than `Schema{INT64}`.
big-andy-coates
commented
Oct 11, 2019
| */ | ||
| public boolean canUpCast(final SqlBaseType to) { | ||
| public boolean canImplicitlyCast(final SqlBaseType to) { |
There was a problem hiding this comment.
Renamed to make the intent more clear.
vcrfxia
approved these changes
Oct 14, 2019
ksql-execution/src/main/java/io/confluent/ksql/execution/util/ExpressionTypeManager.java
Outdated
Show resolved
Hide resolved
ksql-common/src/main/java/io/confluent/ksql/schema/ksql/SqlBaseType.java
Outdated
Show resolved
Hide resolved
vcrfxia
changed the title
…eType.java Co-Authored-By: Victoria Xia <victoria.f.xia281@gmail.com>
purplefox
approved these changes
Oct 15, 2019
| */ | ||
| public boolean canUpCast(final SqlBaseType to) { | ||
| public boolean canImplicitlyCast(final SqlBaseType to) { |
ksql-execution/src/test/java/io/confluent/ksql/execution/util/ExpressionTypeManagerTest.java
Outdated
Show resolved
Hide resolved
ksql-execution/src/test/java/io/confluent/ksql/execution/util/ExpressionTypeManagerTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #3405, #3344
This commit enhances the processing of
CASEstatements so that bothTHENand the default return types can beNULL.At least one branch must be non-null so that KSQL can determine the result type of the statement.
All non-null branches must have the same result schema, i.e. we don't (yet) do any implicit casting of numeric types.
The commit also improves some error messages by using KSQL types rather than connect schema types so that error messages use, for example,
BIGINTrather thanSchema{INT64}.Testing done
Usual
Reviewer checklist