feat: update healthcheck response detail to be a class

ksql-rest-app/src/main/java/io/confluent/ksql/rest/healthcheck/HealthcheckAgent.java

@@ -18,6 +18,7 @@
 import com.google.common.collect.ImmutableList;
 import io.confluent.ksql.rest.client.RestResponse;
 import io.confluent.ksql.rest.entity.HealthcheckResponse;
+import io.confluent.ksql.rest.entity.HealthcheckResponseDetail;
 import io.confluent.ksql.rest.entity.KsqlEntityList;
 import io.confluent.ksql.rest.server.KsqlRestConfig;
 import io.confluent.ksql.services.ServiceContext;
@@ -46,12 +47,13 @@ public HealthcheckAgent(final ServiceContext serviceContext, final KsqlRestConfi
   }
 
   public HealthcheckResponse checkHealth() {
-    final Map<String, Boolean> results = DEFAULT_CHECKS.stream()
+    final Map<String, HealthcheckResponseDetail> results = DEFAULT_CHECKS.stream()
         .collect(Collectors.toMap(
             Check::getName,
-            check -> isSuccessful(check.getKsqlStatement())
+            check -> new HealthcheckResponseDetail(isSuccessful(check.getKsqlStatement()))
         ));
     final boolean allHealthy = results.values().stream()
+        .map(HealthcheckResponseDetail::getIsHealthy)
         .reduce(Boolean::logicalAnd)
         .orElse(true);
     return new HealthcheckResponse(allHealthy, results);

ksql-rest-app/src/test/java/io/confluent/ksql/rest/healthcheck/HealthcheckAgentTest.java

@@ -84,8 +84,8 @@ public void shouldCheckHealth() {
 
     // Then:
     verify(ksqlClient, atLeastOnce()).makeKsqlRequest(eq(SERVER_URI), any());
-    assertThat(response.getDetails().get("metastore"), is(true));
-    assertThat(response.getDetails().get("kafka"), is(true));
+    assertThat(response.getDetails().get("metastore").getIsHealthy(), is(true));
+    assertThat(response.getDetails().get("kafka").getIsHealthy(), is(true));
     assertThat(response.getIsHealthy(), is(true));
   }
 
@@ -99,7 +99,7 @@ public void shouldReturnUnhealthyIfMetastoreCheckFails() {
     final HealthcheckResponse response = healthcheckAgent.checkHealth();
 
     // Then:
-    assertThat(response.getDetails().get("metastore"), is(false));
+    assertThat(response.getDetails().get("metastore").getIsHealthy(), is(false));
     assertThat(response.getIsHealthy(), is(false));
   }
 
@@ -113,7 +113,7 @@ public void shouldReturnUnhealthyIfKafkaCheckFails() {
     final HealthcheckResponse response = healthcheckAgent.checkHealth();
 
     // Then:
-    assertThat(response.getDetails().get("kafka"), is(false));
+    assertThat(response.getDetails().get("kafka").getIsHealthy(), is(false));
     assertThat(response.getIsHealthy(), is(false));
   }
 }

ksql-rest-model/src/main/java/io/confluent/ksql/rest/entity/HealthcheckResponse.java

@@ -26,12 +26,12 @@
 @Immutable
 public final class HealthcheckResponse {
   private final boolean isHealthy;
-  private final Map<String, Boolean> details;
+  private final Map<String, HealthcheckResponseDetail> details;
 
   @JsonCreator
   public HealthcheckResponse(
       @JsonProperty("isHealthy") final boolean isHealthy,
-      @JsonProperty("details") final Map<String, Boolean> details
+      @JsonProperty("details") final Map<String, HealthcheckResponseDetail> details
   ) {
     this.isHealthy = isHealthy;
     this.details = Objects.requireNonNull(details, "details");
@@ -41,7 +41,7 @@ public boolean getIsHealthy() {
     return isHealthy;
   }
 
-  public Map<String, Boolean> getDetails() {
+  public Map<String, HealthcheckResponseDetail> getDetails() {
     return details;
   }
 

ksql-rest-model/src/main/java/io/confluent/ksql/rest/entity/HealthcheckResponseDetail.java

@@ -0,0 +1,58 @@
+/*
+ * Copyright 2019 Confluent Inc.
+ *
+ * Licensed under the Confluent Community License (the "License"); you may not use
+ * this file except in compliance with the License.  You may obtain a copy of the
+ * License at
+ *
+ * http://www.confluent.io/confluent-community-license
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OF ANY KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations under the License.
+ */
+
+package io.confluent.ksql.rest.entity;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.google.errorprone.annotations.Immutable;
+import java.util.Objects;
+
+@JsonIgnoreProperties(ignoreUnknown = true)
+@Immutable
+public final class HealthcheckResponseDetail {
+  private final boolean isHealthy;
+
+  @JsonCreator
+  public HealthcheckResponseDetail(
+      @JsonProperty("isHealthy") final boolean isHealthy
+  ) {
+    this.isHealthy = isHealthy;
+  }
+
+  public boolean getIsHealthy() {
+    return isHealthy;
+  }
+
+  @Override
+  public boolean equals(final Object o) {
+    if (this == o) {
+      return true;
+    }
+
+    if (o == null || getClass() != o.getClass()) {
+      return false;
+    }
+
+    final HealthcheckResponseDetail that = (HealthcheckResponseDetail) o;
+    return isHealthy == that.isHealthy;
+  }
+
+  @Override
+  public int hashCode() {
+    return Objects.hash(isHealthy);
+  }
+}