Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change /metadata REST path to /v1/metadata #3467

Merged
merged 4 commits into from
Oct 10, 2019
Merged

feat: change /metadata REST path to /v1/metadata #3467

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
383e708
feat: add 'path' and 'clusters' to /metadata/id
spena Oct 2, 2019
31920ee
feat: change /metadata path to /v1/metadata
spena Oct 3, 2019
4c52dc4
test: fix KsqlAuthorizationFilterTest
spena Oct 3, 2019
87b0202
fix: replace assertEquals for assertThat
spena Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix KsqlAuthorizationFilterTest
  • Loading branch information
@spena
spena committed Oct 10, 2019
commit 4c52dc46edb5c88441fa33011fe2f5951084e896
4 changes: 2 additions & 2 deletions ...-app/src/test/java/io/confluent/ksql/rest/server/filters/KsqlAuthorizationFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public void filterShouldAbortIfAuthorizationIsDenied() {
@Test
public void filterShouldContinueOnUnauthorizedMetadataPath() {
// Given:
ContainerRequest request = givenRequestContext(userPrincipal, "GET", "metadata");
ContainerRequest request = givenRequestContext(userPrincipal, "GET", "v1/metadata");

// When:
authorizationFilter.filter(request);
Expand All @@ -103,7 +103,7 @@ public void filterShouldContinueOnUnauthorizedMetadataPath() {
@Test
public void filterShouldContinueOnUnauthorizedMetadataIdPath() {
// Given:
ContainerRequest request = givenRequestContext(userPrincipal, "GET", "metadata/id");
ContainerRequest request = givenRequestContext(userPrincipal, "GET", "v1/metadata/id");

// When:
authorizationFilter.filter(request);
Expand Down