feat(static): support for partial datetimes on WindowStart bounds
#3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the change you no longer need to supply the full datetime when adding bounds on `WindowStart`. You can drop precision on the right as much as you like, all the way until you have only a year. For example, ```sql SELECT * FROM AGGREGATE WHERE '2020-02-23T23:45' <= WindowStart AND WindowStart < '2020-02-23T24' AND ROWKEY='10'; ``` Numeric timezones are now also supported ```sql SELECT * FROM AGGREGATE WHERE ROWKEY='10' AND WindowStart='2020-02-23T22:45:12.000-0100'; ```
2 tasks
rodesai
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the change you no longer need to supply the full datetime when adding bounds on
WindowStart. You can drop precision on the right as much as you like, all the way until you have only a year. For example,Numeric timezones are now also supported
cc @derekjn , @MichaelDrogalis
This also fixes a bug in the original Rowtime rewriter code where it was ignoring the time part of datetimes.
Testing done
usual
Reviewer checklist