Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error message on query or print statement on /ksql (MINOR) #3337

Merged
merged 1 commit into from
Sep 17, 2019
Merged

fix: improve error message on query or print statement on /ksql (MINOR) #3337

merged 1 commit into from
Sep 17, 2019

Conversation

big-andy-coates
Copy link
Contributor

@big-andy-coates big-andy-coates commented Sep 12, 2019 •
edited
Loading

Description

If someone issues a PRINT or SELECT statement to the normal HTTP /ksql endpoint it returns an error. The previous error talked about RUN SCRIPT, which is misleading. We don't even have RUN SCRIPT anymore.

RUN SCRIPT cannot be used with the following statements:
* PRINT
* SELECT

New error message just tells users to target such statements to the websocket endpoint /query

The following statement types should be issued to the websocket endpoint '/query':
* PRINT
* SELECT

Testing done

mvn test

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates
fix: improve error message on query or print statement on /ksql
a2446b8 
If someone issues a `PRINT` or `SELECT` statement to the normal HTTP `/ksql` endpoint it returns an error. The previous error talked about `RUN SCRIPT`, which is misleading. We don't even have `RUN SCRIPT` anymore.

New error message just tells users to target such statements to the websocket endpoint `/query`
@big-andy-coates big-andy-coates requested a review from a team as a code owner September 12, 2019 13:39
vcrfxia
vcrfxia approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@vcrfxia vcrfxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vcrfxia vcrfxia requested a review from a team September 16, 2019 22:01
@big-andy-coates big-andy-coates merged commit dae28eb into confluentinc:master Sep 17, 2019
@big-andy-coates big-andy-coates deleted the run_script_error branch September 17, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcrfxia vcrfxia vcrfxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-andy-coates @vcrfxia