feat(data-gen): support KAFKA format in DataGen #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksql-data-gen now supports a `key-format` and `value-format`, rather than the previous `format`. `format` is still accepted to maintain backwards compatibility, however, its use is deprecated. `key-format` supports the existing formats and the new `KAFKA` format that writes data using Kafka's inbuilt serializers. `value-format` won't work with the `KAFKA` format as the value schemas have multiple fields. `key-format` defaults to `KAFKA`. This is backwards compatible as keys were previously serialized using `StringSerializer`. `value-format` defaults to `JSON`, as was the case for the old `format` option.
JimGalasyn
reviewed
Jul 23, 2019
JimGalasyn
reviewed
Jul 23, 2019
JimGalasyn
reviewed
Jul 23, 2019
JimGalasyn
reviewed
Jul 23, 2019
Co-Authored-By: Jim Galasyn <jim.galasyn@confluent.io>
Co-Authored-By: Jim Galasyn <jim.galasyn@confluent.io>
Co-Authored-By: Jim Galasyn <jim.galasyn@confluent.io>
Co-Authored-By: Jim Galasyn <jim.galasyn@confluent.io>
agavra
approved these changes
Jul 30, 2019
ksql-examples/src/main/java/io/confluent/ksql/datagen/DataGenProducer.java
Outdated
Show resolved
Hide resolved
ksql-examples/src/main/java/io/confluent/ksql/datagen/ProducerFactory.java
Outdated
Show resolved
Hide resolved
ksql-examples/src/main/java/io/confluent/ksql/datagen/SchemaRegistryClientFactory.java
Show resolved
Hide resolved
# Conflicts: # ksql-examples/src/main/java/io/confluent/ksql/datagen/AvroProducer.java # ksql-examples/src/main/java/io/confluent/ksql/datagen/DelimitedProducer.java # ksql-examples/src/main/java/io/confluent/ksql/datagen/JsonProducer.java
|
Thanks @big-andy-coates. We do use ksql-datagen in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ksql-data-gen now supports a
key-formatandvalue-format, rather than the previousformat.formatis still accepted to maintain backwards compatibility, however, its use is deprecated.key-formatsupports the existing formats and the newKAFKAformat that writes data using Kafka's inbuilt serializers.value-formatwon't work with theKAFKAformat as the value schemas have multiple fields.key-formatdefaults toKAFKA. This is backwards compatible as keys were previously serialized usingStringSerializer.value-formatdefaults toJSON, as was the case for the oldformatoption.As part of this work I've moved some functionality from the
IntegrationTestHarnesswhich isn't available inksql-examplesinto our test Kafka cluster class, which is available.cc @rmoff - is there any examples / training material that needs updating to reflect the change from
formattovalue-format?Testing done
Functional test added.
Reviewer checklist