Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misplaced commas when formatting CTAS statements #3058

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

vinothchandar
Copy link
Contributor

  • commas now placed after each projection field on same line
  • fixed unit tests to reflect new format

Description

Fixes #3014, to place commas on the same line as the field

Testing done

Fixed unit tests and also verified on ksql commandline and confluent UI locally.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

  - commas now placed after each projection field on same line
  - fixed unit tests to reflect new format
@vinothchandar vinothchandar requested a review from a team as a code owner July 8, 2019 22:47
@ghost
Copy link

ghost commented Jul 8, 2019

It looks like @vinothchandar hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vinothchandar
Copy link
Contributor Author

@hjafarpour anything else to do before you or someone else merges?

@apurvam
Copy link
Contributor

apurvam commented Jul 10, 2019

@vinothchandar feel free to merge.

@vinothchandar vinothchandar merged commit c05615d into confluentinc:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run script on query file shows misplaced commas
3 participants