Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add config for custom metrics tags (5.3.x) #2996

Merged
merged 2 commits into from
Jul 19, 2019
Merged

feat: add config for custom metrics tags (5.3.x) #2996

merged 2 commits into from
Jul 19, 2019

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Jun 20, 2019

Description

Backport changes from #2971 to 5.3.x.

Testing done

Updated unit tests.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested review from JimGalasyn and a team as code owners June 20, 2019 17:16
@vcrfxia vcrfxia mentioned this pull request Jun 20, 2019
Merged
2 tasks
JimGalasyn
JimGalasyn approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@JimGalasyn JimGalasyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vcrfxia vcrfxia changed the title Add config for custom metrics tags (5.3.x) feat: add config for custom metrics tags (5.3.x) Jul 19, 2019
@vcrfxia vcrfxia merged commit 76f5590 into confluentinc:5.3.x Jul 19, 2019
@vcrfxia vcrfxia deleted the custom-metrics-tags-5.3 branch July 19, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra approved these changes

@JimGalasyn JimGalasyn JimGalasyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vcrfxia @agavra @JimGalasyn