Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Queries: Choose correct network interface to advertise for ksql rest api #4151

Closed
AlanConfluent opened this issue Dec 16, 2019 · 0 comments · Fixed by #4169
Closed

Pull Queries: Choose correct network interface to advertise for ksql rest api #4151

AlanConfluent opened this issue Dec 16, 2019 · 0 comments · Fixed by #4169
Assignees
Labels
bug P0 Denotes must-have for a given milestone
Milestone

Comments

@AlanConfluent
Copy link
Member

Describe the bug
The service appears to grab the 0th network interface and broadcasts that. This may not be the one the environment is set up to use to contact between nodes.

@vinothchandar vinothchandar added this to the 0.7.0 milestone Dec 17, 2019
@vinothchandar vinothchandar changed the title Choose correct network interface to advertise for ksql rest api Pull Queries: Choose correct network interface to advertise for ksql rest api Dec 17, 2019
@vinothchandar vinothchandar added the P0 Denotes must-have for a given milestone label Dec 17, 2019
@big-andy-coates big-andy-coates self-assigned this Dec 18, 2019
big-andy-coates added a commit to big-andy-coates/ksql that referenced this issue Dec 18, 2019
Fixes: confluentinc#4142
Fixes: confluentinc#4151
Fixes: confluentinc#4152

Introduces a new `inter.node.listener` that can be used to specify a URL that the node can be contacted on by other nodes.  This can be different to the listeners defined in `listeners`. This can be required if `listeners` is set to a wildcard address, i.e. IPv4 `0.0.0.0` or IPv6 `[::]`, or if the node sits behind network infrastructure that requires other nodes to reach it using a different URL.

If `inter.node.listener` is not set it still defaults to the first listener in `listener` config. However, it now replaces an wildcard address with `localHost`. This means inter-node comms is still possible for nodes running on the same host.

Warnings are logged if the inter-node listener resolves to a loopback or local address.
big-andy-coates added a commit that referenced this issue Dec 20, 2019
* fix: pull queries should work across nodes

Fixes: #4142
Fixes: #4151
Fixes: #4152

Introduces a new `inter.node.listener` that can be used to specify a URL that the node can be contacted on by other nodes.  This can be different to the listeners defined in `listeners`. This can be required if `listeners` is set to a wildcard address, i.e. IPv4 `0.0.0.0` or IPv6 `[::]`, or if the node sits behind network infrastructure that requires other nodes to reach it using a different URL.

If `inter.node.listener` is not set it still defaults to the first listener in `listener` config. However, it now replaces an wildcard address with `localHost`. This means inter-node comms is still possible for nodes running on the same host.

Warnings are logged if the inter-node listener resolves to a loopback or local address.
big-andy-coates added a commit to big-andy-coates/ksql that referenced this issue Jan 10, 2020
Backport of confluentinc#4169

Fixes: confluentinc#4142
Fixes: confluentinc#4151
Fixes: confluentinc#4152

Introduces a new `inter.node.listener` that can be used to specify a URL that the node can be contacted on by other nodes.  This can be different to the listeners defined in `listeners`. This can be required if `listeners` is set to a wildcard address, i.e. IPv4 `0.0.0.0` or IPv6 `[::]`, or if the node sits behind network infrastructure that requires other nodes to reach it using a different URL.

If `inter.node.listener` is not set it still defaults to the first listener in `listener` config. However, it now replaces an wildcard address with `localHost`. This means inter-node comms is still possible for nodes running on the same host.

Warnings are logged if the inter-node listener resolves to a loopback or local address.

(cherry picked from commit 0ac71cf)
big-andy-coates added a commit that referenced this issue Jan 26, 2020
Backport of #4169

Fixes: #4142
Fixes: #4151
Fixes: #4152

Introduces a new `inter.node.listener` that can be used to specify a URL that the node can be contacted on by other nodes.  This can be different to the listeners defined in `listeners`. This can be required if `listeners` is set to a wildcard address, i.e. IPv4 `0.0.0.0` or IPv6 `[::]`, or if the node sits behind network infrastructure that requires other nodes to reach it using a different URL.

If `inter.node.listener` is not set it still defaults to the first listener in `listener` config. However, it now replaces an wildcard address with `localHost`. This means inter-node comms is still possible for nodes running on the same host.

Warnings are logged if the inter-node listener resolves to a loopback or local address.

(cherry picked from commit 0ac71cf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P0 Denotes must-have for a given milestone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants