This repository has been archived by the owner on Dec 19, 2021. It is now read-only.
Initial refactoring of the dashboard logic #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickSchimek
requested review from
TNorbury,
aedwardg,
htharker42 and
Chris-Boe
NickSchimek
force-pushed
the
rfctr_dash_model
branch
from
008bdd8
to
5d62c87
Compare
Right now this is duplicated, because the frontend needs to be updated to use the endpoint dashboard instead of widget.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the dashboard widget. Moved the responsibility for serializing the objects into a model.
I did find one bug while doing this.
The "This Week" for displaying the manager date was never executing, because it had the same logic as the one for "Yesterday".
Created new scopes:
TicketModel.new() -> Returns all tickets with the status new
What issue is this solving?
Closes codeforpdx/dwellingly-app/issues/681