This repository has been archived by the owner on Dec 19, 2021. It is now read-only.
Implement strategy for unique validations #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickSchimek
force-pushed
the
fix_granting_user_access
branch
from
e33935b
to
fd75923
Compare
NickSchimek
changed the title
TNorbury
previously approved these changes
Oct 18, 2021
NickSchimek
added
do not merge
Chris-Boe
previously approved these changes
Oct 21, 2021
Co-authored-by: Chris Boe <cboe15@gmail.com>
Chris-Boe
approved these changes
Oct 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid the false positives when validating a unique field.
Uses Anthony's context implementation to pass the original value of fields, except the context is assigned automatically. It just needs to be explicitly set in the model, and then it will be available in the schema's for validations.
Refactored the app, and implemented this on all unique fields.
Fixes codeforpdx/dwellingly-app/issues/709