Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differ is incorrectly treating attribute operations on elements #4526

Closed
scofalik opened this issue Jul 23, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1765
Closed

Differ is incorrectly treating attribute operations on elements #4526

scofalik opened this issue Jul 23, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1765
Assignees
@scofalik
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 26

Comments

@scofalik
Copy link
Contributor

AttributeOperations are shallow. It means that, for example, if AttributeOperation changes range [ 1 ] - [ 3 ] only elements on offset 1 and 2 are changed but their children not.

In Differ, we forgot about that and by mistake Differ tried to work on children of elements when attribute operation was executed which leads to a crash in certain scenarios.
@scofalik scofalik self-assigned this Jul 23, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-engine Jul 23, 2019
Merge pull request #1765 from ckeditor/t/1764
482e55e 
Fix: Prevented `Differ` crashing in some scenarios involving attribute changes on elements. Closes #1764.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 26 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 26
2 participants
@scofalik @mlewand