Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find module '@glimmer/syntax' with 0.4 #21

Open
samselikoff opened this issue Jun 20, 2018 · 5 comments
Open

Cannot find module '@glimmer/syntax' with 0.4 #21

samselikoff opened this issue Jun 20, 2018 · 5 comments

Comments

@samselikoff
Copy link
Contributor

Latest published seems to be 0.4, but it throws error:

Cannot find module '@glimmer/syntax'

Downgrading to 0.3.5 seemed to get me going.

Should we make 0.4 a pre-release? I couldn't find it in Github.

Let me know if I can help!

@cibernox
Copy link
Owner

We must make this not rely on any specific version of @glimmer/syntax but use this.syntax from whatever version the app uses

@jrjohnson
Copy link

@cibernox how should an addon include @glimmer/syntax? I'm trying to update @fortawesome/ember-font-awesome to 0.4.0, but I get

Template Compiler Error (broccoli-persistent-filter:TemplateCompiler) in dummy/templates/application.hbs

this.syntax.parse is not a function

when running tests. My first guess is that addons don't provide a version of @glimmer/syntax by default, but I'm not sure.

@cibernox
Copy link
Owner

cibernox commented Feb 4, 2019

I need to revisit this, I believe we shouldn't be importing the syntax from anywhere but rather access whatever version is available in the context.

@jrjohnson
Copy link

My new idea is to add a dev-dependency on @glimmer/syntax. What I'm not sure about is why this addon doesn't have this already and how I would ensure that apps that consume it do.

@jrjohnson
Copy link

Actually looking at some apps @glimmer/syntax doesn't appear with npm ls @glimmer/syntax other that from this package. So I'm not sure this is something that would be available in any context and should probably be provided as a dependency of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants