Proof read INTER-BANK_COMMUNICATION #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wopian
requested changes
May 1, 2017
| @@ -87,7 +87,7 @@ SUPDACAL TS MPTEMP | |||
| ROR SUPERBNK # SAVE FBANK IN BITS 15-11, AND | |||
| XCH MPTEMP # SUPERBANK IN BITS 7-5. | |||
| MASK LOW10 | |||
| XCH L # SAVE REL. ADR. IN BANK, FETCH SUPERBITS | |||
| XCH L # SAVE REL. ADR. IN BANK, FETCH SUPERBITS. | |||
| # --------- ------- ------------ ------------ --------- | ||
| # SUPERBANK 3 OXX 2000 - 3777 30 - 37 70000 - 107777 (WHERE XX CAN BE ANYTHING AND | ||
| # SUPERBANK SETTING S-REG. VALUE BANK NUMBERS ADDRESSES | ||
| # ---------- ------- ------------ ------------ ------------ |
| # SUPERBANK 3 OXX 2000 - 3777 30 - 37 70000 - 107777 (WHERE XX CAN BE ANYTHING AND | ||
| # SUPERBANK SETTING S-REG. VALUE BANK NUMBERS ADDRESSES | ||
| # ---------- ------- ------------ ------------ ------------ | ||
| # SUPERBANK 3 0XX 2000 - 3777 30 - 37 70000 - 107777 (WHERE XX CAN BE ANYTHING AND |
| # THE USER) | ||
| # *** THIS ROUTINE MAY BE CALLED BY ANY PROGRAM LOCATED IN BANKS 00 - 27. I.E., NO PROGRAM LIVING IN ANY | ||
| # *** THIS ROUTINE MAYBE CALLED BY ANY PROGRAM LOCATED IN BANKS 00 - 27. I.E., NO PROGRAM LIVING IN ANY |
There was a problem hiding this comment.
✔️ MAYBE
✨ Can you add a double space between *** and THIS, and again on line below between SUPERSW. and ***
| # SUPERBANK SHOULD USE SUPERSW. *** | ||
| # | ||
| # SUPERSW MAY BE CALLED IN THIS FASHION: | ||
| # CAF ABBCON WHERE -- ABBCON BBCON SOMETHING -- | ||
| # SUPERSW MAYBE CALLED IN THIS FASHION: |
| # SUPERSW MAY BE CALLED IN THIS FASHION: | ||
| # CAF ABBCON WHERE -- ABBCON BBCON SOMETHING -- | ||
| # SUPERSW MAYBE CALLED IN THIS FASHION: | ||
| # CAF ABBCON WHERE -- ABBCON BBCON SOMETHIN -- |
There was a problem hiding this comment.
✔️ SOMETHIN
❌ Only 3 spaces between ABBCON and BBCON
❌ Only 2 spaces between BBCON and SOMETHIN
✨ Can you add double spaces after WHERE, -- and SOMETHIN
| # TCR SUPERSW (THE SUPERBNK BITS ARE IN THE BBCON) | ||
| # ... ... | ||
| # . . | ||
| # . . | ||
| # OR IN THIS FASHION: | ||
| # OR IN THIS FASHION : |
|
Thanks for the feedback! I introduced the changes you requested. :) |
wopian
approved these changes
May 1, 2017
|
Thanks! Nice to see so many contributions all of a sudden 😃 as I just don't have the time to do these myself until summer 😢 |
|
No problem, it was kinda fun! Maybe I'll do another if I find the time. :) |
|
Yes we .
Ante cualquier duda responda este correo.
Juan Manuel Ramallo
Whatsapp:
+5493513118724
…-------- Mensaje original --------
De: Felix Wittwer <notifications@github.com>
Fecha: 1/5/17 3:47 AM (GMT-03:00)
A: chrislgarry/Apollo-11 <Apollo-11@noreply.github.com>
CC: Subscribed <subscribed@noreply.github.com>
Asunto: Re: [chrislgarry/Apollo-11] Proof read INTER-BANK_COMMUNICATION (#291)
No problem, it was kinda fun! Maybe I'll do another if I find the time. :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#291 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFVnJ6357A2tyPJ5U8nKDujwiycgjQXhks5r1YAbgaJpZM4NMj3s>.
|
GulajavaMinistudio
added a commit
to GulajavaMinistudio/Apollo-11
that referenced
this pull request
May 2, 2017
Proof read INTER-BANK_COMMUNICATION (chrislgarry#291)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #216.
I added a period, reformatted the table at the bottom and reintroduced some typos that were removed during the transcription.
I am not sure about line 110, though. Should it be changed back to
CAF? RSB changed it toCA, back in 2009.