Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cors env #388

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Add cors env #388

merged 1 commit into from
Aug 14, 2020

Conversation

zhouzhuojie
Copy link
Collaborator

Description

fix #387. I think it makes sense to config CORS for other browser clients.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Merging #388 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files          27       27           
  Lines        1755     1755           
=======================================
  Hits         1457     1457           
  Misses        214      214           
  Partials       84       84           
Impacted Files Coverage Δ
pkg/config/middleware.go 68.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea10604...2a2e892. Read the comment docs.

@zhouzhuojie zhouzhuojie merged commit 9c5e30c into master Aug 14, 2020
@zhouzhuojie zhouzhuojie deleted the zz/add-cors-env branch August 14, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS Error with Custom Headers
3 participants