Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] restore deleted flags #215

Closed
zhouzhuojie opened this issue Feb 6, 2019 · 1 comment · Fixed by #379
Closed

[feat] restore deleted flags #215

zhouzhuojie opened this issue Feb 6, 2019 · 1 comment · Fixed by #379
Labels
enhancement feature request good first issue help wanted

Comments

@zhouzhuojie
Copy link
Collaborator

Some flags are sensitive, if it's deleted, make sure it's also easy to restore as well. Currently, in gorm, everything is soft deleted. I think this feature will need the following changes:

  • UI front page, to not only show the current flags, but also a section to show deleted flags.
  • A new parameter in GET /flags?deleted=true to get deleted flags
  • A new route POST /flags/<id>/restore to restore deleted flags
  • A new UI button to restore deleted flags
@kenli-rubrik kenli-rubrik mentioned this issue May 15, 2019
Closed
@Shailendra1118
Copy link

Shailendra1118 commented Oct 19, 2019 •
edited
Loading

@zhouzhuojie By POST /flags/<id>/restore do you mean by creating a new flag with values same as deleted ? I think that is the way because DelatedAt of gorm Model is updatable.

@silent1mezzo silent1mezzo mentioned this issue Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature request good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow users the ability to restore deleted flags
2 participants
@zhouzhuojie @Shailendra1118