fixbug: Ping should put resource back to the pool #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/cectc/dbpack/issues/
Ⅰ. Describe what this PR did
I found dbpack won`t work as mysql proxy when waiting for a few minutes, and the ping would get the resource from the pool but not put it back to the pool. If the default config capacity is 30 and ping_interval is 20s, the dbpack won`t work after 30*20s=600s for the pool exhausted.
Ⅱ. Does this pull request fix one issue?
no.
Ⅲ. Why don't you add test cases (unit test/integration test)?
I had test it on my local enviroment.
Ⅳ. Describe how to verify it
Run the sample, and wait for more than 10 minutes.
Ⅴ. Special notes for reviews
nothing.