action: Use latest/candidate by default
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default snap channel for LXD was changed from `latest/stable` (feature release) to `5.21/stable` (LTS release) on April 2024. With that change, a huge majority of casual LXD users will simply land on the `5.21/stable` channel meaning that very few will actually test the feature releases leading up to the next LTS. If few are testing those feature releases, what will eventually land in the next LTS will be at higher risks of introducing regressions. Switching this action to use `latest/candidate` should strike a good balance between stability and QA needs for LXD. `latest/candidate` is heavily tested but slightly more risky than the older `latest/stable` channel this action used when a simple `snap install lxd` was equivalent to `snap install lxd --channel=latest/stable`. This slight risk increase is deemed OK as this action is used on CI instances that are ephemeral in nature and where the consuming users generally want to have early signs of problems. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…efault Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
LXD 4.0 will go EOL on June 2025 and 5.21 is the current LTS. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Also fix the version comparison to work with the new "LTS" string being reported by `lxd version`. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
3.0/stable no longer exist. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
|
@tomponline Please take a look. |
|
@barrettj12 I'm looking forward to getting your feedback on this PR, thanks! |
|
@simondeziel i have emailed Jordan about this too. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default snap channel for LXD was changed from
latest/stable(featurerelease) to
5.21/stable(LTS release) on April 2024. With that change, a hugemajority of casual LXD users will simply land on the
5.21/stablechannelmeaning that very few will actually test the feature releases leading up to the
next LTS.
If few are testing those feature releases, what will eventually land in the
next LTS will be at higher risks of introducing regressions.
Switching this action to use
latest/candidateshould strike a good balancebetween stability and QA needs for LXD.
latest/candidateis heavily testedbut slightly more risky than the older
latest/stablechannel this action usedwhen a simple
snap install lxdwas equivalent tosnap install lxd --channel=latest/stable.This slight risk increase is deemed OK as this action is used on CI instances
that are ephemeral in nature and where the consuming users generally want to
have early signs of problems.