New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use utf-8 for client config file #168

Merged

Perfect5th merged 1 commit into canonical:master from Perfect5th:2028516-allow-unicode-settings

Aug 14, 2023

Contributor

Perfect5th commented Jul 25, 2023

See https://bugs.launchpad.net/landscape-client/+bug/2028516 for background:

There's actually no good reason not to accept valid utf-8 as the computer-title. Our message schema declares the title as unicode, and it is stored on the server side as unicode.

This bug exists because when we write the provided config to /etc/landscape/client.conf we assume the encoding of that file is ASCII. We shouldn't need to make this assumption, and should instead enforce ASCII-ness on a per-field basis (as we do for other types, such as fields that must be integers, etc).


          use utf-8 for client config file

77b1551

silverdrake11 approved these changes

View reviewed changes

Contributor

silverdrake11 left a comment

LGTM

Perfect5th merged commit f701bed into canonical:master

5 checks passed

Perfect5th deleted the 2028516-allow-unicode-settings branch

August 14, 2023 20:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet