Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sign in csv export #1119

Open
markdavidjohnson opened this issue Apr 16, 2023 · 1 comment
Open

No sign in csv export #1119

markdavidjohnson opened this issue Apr 16, 2023 · 1 comment

Comments

@markdavidjohnson
Copy link

Description:
When exporting CSVs from the All Activities view, there is currently no difference in the sign of amounts for received vs sent. This can be confusing for users when analyzing their transaction data.

File:
lib/bloc/csv_exporter.dart

Issue:
This line is responsible for adding the amount to the CSV export without differentiating the signs for received or sent transactions:
paymentItem.add(paymentInfo.amount.toString());

Suggested Fix:
Modify the line to assign the correct sign to the amount based on whether it's a received or sent transaction:
paymentItem.add(((paymentInfo.type == PaymentType.SENT || paymentInfo.type == PaymentType.WITHDRAWAL ? -1 : 1) * paymentInfo.amount).toString());

This change will apply a negative sign to sent and withdrawal transactions, making it easier for users to analyze their transaction data.

@tlindi
Copy link
Contributor

tlindi commented Apr 21, 2023

+1 for this.

Also verify similar for fees too, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants