[CLOSED] Some unit test fixes

[core-ai-bot]

Issue by MarcelGerber
Thursday May 19, 2016 at 23:08 GMT
Originally opened as adobe/brackets#12437

---

Fixes the test failures we see on current master for ProjectModel (Unit), ExtensionManager (Unit) and CSS Code Hints (Extensions).

See the individual commit messages for more information.

---

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/12437/commits

[core-ai-bot]

Comment by nethip
Friday May 20, 2016 at 05:50 GMT

---

Thanks for fixing these@MarcelGerber . These changes look good to me.

[core-ai-bot]

Comment by ficristo
Friday May 20, 2016 at 08:32 GMT

---

@MarcelGerber do you know why the ProjectModel tests needed to be changed?

[core-ai-bot]

Comment by MarcelGerber
Friday May 20, 2016 at 08:42 GMT

---

It's because of this newly introduced change: adobe/brackets@a505026#diff-d93c1799d928e189223d1d4fa75f80dcR816.
Our isWithinProject check works by checking if the file/folder path (/foo before this change) begins with the project root path (/foo/).
I made sure that every path we pass to the function has a trailing /, so this doesn't cause any problems.

[core-ai-bot]

Comment by ficristo
Friday May 20, 2016 at 08:45 GMT

---

Thank you!