Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dropping links to zip files #554

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Support dropping links to zip files #554

merged 1 commit into from
Sep 12, 2019

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Sep 12, 2019

Changelog

You can now drop a link to a BMS archive (.zip, .rar) from another web page into the “Custom BMS” panel. When you do it, Bemuse will attempt to download and extract the file. Note that for this to work, the web server that serves the file must set up cross-origin resource sharing to allow Bemuse to download it. Both Dropbox and IPFS gateways has this set up already.

Dropbox URL normalization code is based on [@Nekokan]’s Dropbox Replacer, thanks!

@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #554 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
- Coverage   80.86%   80.85%   -0.01%     
==========================================
  Files         156      156              
  Lines        4760     4763       +3     
  Branches      184      184              
==========================================
+ Hits         3849     3851       +2     
- Misses        862      863       +1     
  Partials       49       49
Impacted Files Coverage Δ
src/app/song-loader/index.js 85.29% <50%> (-1.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 110b875...fceaa0e. Read the comment docs.

release-train bot added a commit that referenced this pull request Sep 12, 2019
release-train bot added a commit that referenced this pull request Sep 12, 2019
@dtinth dtinth merged commit fceaa0e into master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants