Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BMS encoding to be specified through filename. #492

Merged
merged 14 commits into from
Aug 4, 2018
Merged

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Jul 30, 2018

Rationale:

Character set detection is sometimes inaccurate. To allow overriding the encoding without changing content, creators can specify the encoding of the file through file naming.

  • .utf8.bms — Always read as UTF-8
  • .sjis.bms — Always read as Shift-JIS
  • .euc_kr.bms — Always read as EUC-KR

Tasks:

  • bms-js
    • getReaderOptionsFromFilename
    • Implement reader options
    • Publish 3.1.0-1
  • bemuse-notechart
    • NotechartLoader — pass filename
    • Publish
  • bemuse-indexer
    • readBMS — pass filename
    • Publish
  • bemuse
    • Update bemuse-notechart and bemuse-indexer

@codecov-io
Copy link

codecov-io commented Jul 30, 2018

Codecov Report

Merging #492 into master will increase coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #492      +/-   ##
=========================================
+ Coverage   84.09%   84.1%   +0.01%     
=========================================
  Files         170     171       +1     
  Lines        5370    5387      +17     
  Branches        1       1              
=========================================
+ Hits         4516    4531      +15     
- Misses        854     856       +2
Impacted Files Coverage Δ
packages/bms/spec/reader_spec.js 100% <100%> (ø) ⬆️
packages/bemuse-notechart/src/loader/index.js 100% <100%> (ø) ⬆️
packages/bemuse-indexer/src/index.js 93.8% <100%> (+0.05%) ⬆️
packages/bms/src/reader/index.js 85% <100%> (+3.75%) ⬆️
...ges/bms/src/reader/getReaderOptionsFromFilename.js 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634597a...c1d8d3a. Read the comment docs.

@dtinth dtinth merged commit 3d3f24d into master Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants