Add more base64 malformed request tests #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
requested review from
DavidOgunsAWS,
kstich and
mtdowling
as code owners
JordonPhillips
commented
Sep 13, 2021
Comment on lines
+45
to
+47
| // Invalid characters which are commonly used as filename-safe | ||
| // alternatives to + and / | ||
| "-_==" |
There was a problem hiding this comment.
Do we want to accept these or not? They're often used for uri-safe and filename-safe encoding. They can also be percent encoded in the uri case.
This also raises the question of whether media-typed strings should be encoded when used in a URI. Percent encoding should be sufficient there, I think.
There was a problem hiding this comment.
Yeah, percent encoding sounds right to me.
This adds more base64 tests, including ones for strings that use mediaType in places where they need to be encoded.
JordonPhillips
force-pushed
the
more-base-64
branch
from
5520a24
to
06f93a5
Compare
adamthom-amzn
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more base64 tests, including ones for strings that use
mediaType in places where they need to be encoded.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.