Add block apply statements #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a common requirement to need to apply multiple traits to the same
shape. However, this previously required that the shape ID of the trait
is restated for each applied trait. This added a lot of noise in models,
especially when applying traits to members. With this change, multiple
traits can be applied to a shape using a single statement by wrapping
traits in a block ("{" and "}").
kstich
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a common requirement to need to apply multiple traits to the same
shape. However, this previously required that the shape ID of the trait
is restated for each applied trait. This added a lot of noise in models,
especially when applying traits to members. With this change, multiple
traits can be applied to a shape using a single statement by wrapping
traits in a block ("{" and "}").
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.