Add methods for retrieving full paginator output token and item paths. #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2020
kstich
requested changes
Nov 11, 2020
smithy-model/src/main/java/software/amazon/smithy/model/traits/PaginatedTrait.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/PaginationInfo.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/PaginationInfo.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/PaginationInfo.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/PaginatedIndex.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/PaginatedIndex.java
Outdated
Show resolved
Hide resolved
skmcgrail
force-pushed
the
paginators
branch
from
c7dd864
to
ec44431
Compare
skmcgrail
force-pushed
the
paginators
branch
from
ec44431
to
b209eb3
Compare
skmcgrail
changed the title
JordonPhillips
requested changes
Nov 12, 2020
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/PaginationInfo.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/PaginationInfo.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/traits/PaginatedTrait.java
Outdated
Show resolved
Hide resolved
JordonPhillips
approved these changes
Nov 12, 2020
kstich
requested changes
Nov 16, 2020
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/PaginatedIndex.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/PaginationInfo.java
Outdated
Show resolved
Hide resolved
mtdowling
approved these changes
Nov 17, 2020
kstich
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for retrieving the full list of MemberShape paths for the @paginated.outputToken and @paginated.items paths. Currently marked the old methods as deprecated as to better indicate the more desirable retrievers a user should use.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.