Add support for Gradle 6 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates Smithy to build with Gradle 6. Gradle 6 is currently in RC and not yet stable, so this should not be merged until it's actually out. 1. Updates to latest version of SpotBugs to fix a build issue. 2. Updated some Checkstyle configuration to work with newer versions of CheckStyle. 3. Made minor code style tweaks to please CheckStyle.
JordonPhillips
force-pushed
the
gradle6-support
branch
from
cf9a2d4
to
d5f68f7
Compare
|
I rebased this and updated to Gradle 6.8. |
This resolves deprecation notices so that an eventual upgrade to gradle 7 will be relatively smooth.
JordonPhillips
changed the title
srchase
approved these changes
Jan 15, 2021
rschmitt
approved these changes
Jan 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates Smithy to build with Gradle 6. Gradle 6 is currently
in RC and not yet stable, so this should not be merged until it's
actually out.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.