Allow the xmlFlattened trait to be on members #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
approved these changes
Oct 22, 2019
mtdowling
reviewed
Oct 22, 2019
| @@ -148,7 +148,7 @@ structure xmlAttribute {} | |||
|
|
|||
| /// Moves serialized collection members from their collection element to that of | |||
| /// the collection's container. | |||
| @trait(selector: "collection") | |||
| @trait(selector: ":each(collection, structure > :test(member > collection))") | |||
There was a problem hiding this comment.
It would be simpler to do:
:test(collection, member:of(structure) > collection)
kstich
requested changes
Oct 22, 2019
JordonPhillips
force-pushed
the
xml-flatten-member
branch
from
9960946
to
ad470cd
Compare
kstich
reviewed
Oct 22, 2019
kstich
approved these changes
Oct 22, 2019
mtdowling
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.