Allow transforms to remove enum members #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that was preventing enum members from being removable from transforms, such as removeShapesByTag.
srchase
approved these changes
Oct 11, 2022
|
Sweet, I was wondering about what would happen if all of the members are removed since that’s not allowed and if this is catch and how is going to be reported. I don't see any tests covering this case. |
If all the members are removed, the shape should be removed since I'm making use of the code that does just that for unions/structures. I can add a test case tomorrow to cover that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that was preventing enum members from being removable from transforms, such as removeShapesByTag.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.