Add outputToken value clarification for clients #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
approved these changes
Jan 14, 2022
|
LGTM! It might be nice to include some example APIs to test against that expose uncommon behavior, eg. DynamoDB scan items (uses a hashmap), the EC2 APIs with empty tokens. Ideally, of course, we'd have some form of protocol tests for pagination but that's a bigger lift. I understand if we don't want to call out AWS specific stuff in the docs though |
mtdowling
reviewed
Jan 14, 2022
kstich
force-pushed
the
outputToken_clarification
branch
from
69c692f
to
b779f6c
Compare
mtdowling
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1045
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.