Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Make Microsoft.AspNetCore.Mvc.Internal.MiddlewareFilter internal #5432

Closed
pranavkm opened this issue Oct 19, 2016 · 2 comments
Closed

Make Microsoft.AspNetCore.Mvc.Internal.MiddlewareFilter internal #5432

pranavkm opened this issue Oct 19, 2016 · 2 comments
Assignees
@jbagga
Labels
3 - Done task
Milestone
1.1.0

Comments

@pranavkm
Copy link
Contributor

When attempting to add MiddlewareFilter (you really want to add MiddlewareFilterAttribute) as a global filter, this pops up in the intellisense. Maybe we can come up with a better name. Particularly crummy since the former matches the attribute on an action.
@rynowak
Copy link
Member

rynowak commented Oct 19, 2016

Or maybe make it internal for realsies?

@Eilon Eilon added this to the 1.1.0 milestone Oct 24, 2016
@Eilon
Copy link
Member

Eilon commented Oct 24, 2016

Yeah let's just make it actually internal.

@Eilon Eilon changed the title Consider renaming Microsoft.AspNetCore.Mvc.Internal.MiddlewareFilter Make Microsoft.AspNetCore.Mvc.Internal.MiddlewareFilter internal Oct 24, 2016
@jbagga jbagga mentioned this issue Oct 26, 2016
Merged
@jbagga jbagga closed this as completed in 3d2710a Oct 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbagga jbagga

Labels
3 - Done task
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
4 participants
@pranavkm @Eilon @rynowak @jbagga