Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Print warning if .tool-versions or asdfrc contains carriage returns #1561

Merged
merged 1 commit into from
May 28, 2023

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented May 27, 2023

Summary

Title. It was recommended in the linked issue to exit the program as well, but that was not attempted because there are various instances where the code could be ran in subshells (in which case, only the subshell will be exited).

Fixes #1476

@hyperupcall hyperupcall requested a review from a team as a code owner May 27, 2023 06:50
@hyperupcall hyperupcall force-pushed the h-carriage-returns-warning branch 2 times, most recently from 4e168e4 to 6a15b38 Compare May 27, 2023 06:51
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jthegedus
Copy link
Contributor

Hopefully this is no longer an issue.

@jthegedus jthegedus merged commit 097f773 into asdf-vm:master May 28, 2023
@hyperupcall hyperupcall deleted the h-carriage-returns-warning branch May 28, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: asdf install fails if .tool-versions uses carriage returns
2 participants