Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Introduce ASDF_FORCE_PREPEND variable on POSIX entrypoint #1560

Merged
merged 7 commits into from
Jun 9, 2023

Conversation

hyperupcall
Copy link
Contributor

Summary

This variable forces the prepending of the asdf directories to the PATH variable. It does this by removing existing asdf entries in PATH, including an optimization for Bash and Zsh shells.

Fixes #1550

This variable forces the prepending of the asdf directories to the PATH
variable. It does this by removing existing asdf entries in PATH,
including an optimization for Bash and Zsh shells.
@hyperupcall
Copy link
Contributor Author

I'm starting to think that this should be the default on macOS, so users don't end up having to set environment variables when they update. Thoughts?

@jthegedus
Copy link
Contributor

I'm starting to think that this should be the default on macOS, so users don't end up having to set environment variables when they update. Thoughts?

That's probably best. I would like to see the code you would suggest for that.

@hyperupcall
Copy link
Contributor Author

I changed things from relying on the existence of a set variable, to the value of the variable. Now there is documentation which explains the behavior

asdf.sh Show resolved Hide resolved
@Stratus3D
Copy link
Member

Just tested these changes and confirmed they fixed my issue with the path inside tmux sessions.

@Stratus3D
Copy link
Member

@jthegedus are you good with this now?

@Stratus3D
Copy link
Member

Merge so I can easily get this fix on my machines. @jthegedus happy to revert this change if you find issues with what is here.

@Stratus3D Stratus3D merged commit 5b7d0fe into asdf-vm:master Jun 9, 2023
@hyperupcall hyperupcall deleted the h-path-order branch June 9, 2023 02:25
@jthegedus
Copy link
Contributor

@jthegedus are you good with this now?

Yeah, this looks like a good soln for this problem 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: PATH order situationally broken on MacOS
3 participants