-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enforce consistent shell redirection format #1533
fix: enforce consistent shell redirection format #1533
Conversation
I have no objection to this change. I would like to get @Stratus3D opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could go either way on this - I actually wasn't familiar with the &>
shorthand (maybe that's obvious looking at the codebase 😛 ), but it does make the code cleaner.
@hyperupcall &>
isn't POSIX is it? I assume we can only enforce this on Bash files.
I guess if it isn't, we would just want to ensure |
e7ad608
to
246bbd2
Compare
Yeah it's not POSIX, so the rule would have conflicted with ShellCheck in I modified the CheckStyle so this new rule only applies to our |
@hyperupcall Do you mean non-POSIX? We want to apply this to Sorry, I am getting confused. |
@jthegedus My apologies, that was me - fixed |
@jthegedus you can merge whenever you are ready. |
Summary
Make redirections more consistent