Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not use type not exported on older Python versions #1409

Merged
merged 1 commit into from
Dec 30, 2022
Merged

fix: Do not use type not exported on older Python versions #1409

merged 1 commit into from
Dec 30, 2022

Conversation

hyperupcall
Copy link
Contributor

Summary

This fixes an issue I mentioned in #1406, here. Now, the checkstyle.py script runs with Python 3.6.15

@hyperupcall hyperupcall requested a review from a team as a code owner December 29, 2022 23:54
@hyperupcall hyperupcall mentioned this pull request Dec 29, 2022
Merged
@jthegedus jthegedus changed the title fix(checkstyle): Do not use type not exported on older Python versions fix: Do not use type not exported on older Python versions Dec 30, 2022
@jthegedus jthegedus merged commit 7460809 into asdf-vm:master Dec 30, 2022
@github-actions github-actions bot mentioned this pull request Dec 30, 2022
Merged
@jthegedus
Copy link
Contributor

I should have validated this more thoroughly, as I don't think this change qualifies as a fix: in the sense that release-please thinks.

A change to a CI or dev-dep shouldn't qualify as a version change to the codebase unless, as in #1398 , they introduce code changes to the tool itself.

@hyperupcall
Copy link
Contributor Author

hyperupcall commented Dec 30, 2022 •
edited
Loading

Ah, you're right - I guess style or types may have been more appropriate (if they pass the semantic release check). If not, then maybe chore

@hyperupcall hyperupcall deleted the fix-bad-type branch December 30, 2022 09:45
@jthegedus
Copy link
Contributor

In this case, ci or chore would have been preferable.

It was my mistake. Thanks for understanding.

@jthegedus jthegedus mentioned this pull request Jan 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthegedus jthegedus jthegedus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyperupcall @jthegedus