Improve Integer conversion in BigQueryIO's Storage Write API method. #24366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning reviewers. If you would like to opt out of this review, comment R: @apilloud for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
apilloud
reviewed
Nov 28, 2022
| try { | ||
| return Long.valueOf((String) value); | ||
| } catch (NumberFormatException e) { | ||
| // Expected. Element will be added to the failed element PCollection |
There was a problem hiding this comment.
These are going to result in a generic SchemaDoesntMatchException("Unexpected value :"...) being thrown which will make this potentially difficult to debug when it happens. If we can't just let the exception bubble up here, you should wrap it with a new exception rather than just dropping it. (Same thing for the exceptions below.)
There was a problem hiding this comment.
Addressed in the latest commit. Only implemented for the INTEGER type at the moment.
added 3 commits
November 28, 2022 19:59
…Introduced a dedicated Exception. Improved error messages by capturing the source failure and reducing message sizes.
…Introduced a dedicated Exception; improved error messages by capturing the source failure.
added 2 commits
November 30, 2022 10:53
# Conflicts: # sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java # sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProtoTest.java
|
Reminder, please take a look at this pr: @apilloud @ahmedabu98 |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @lukecwik for label java. Available commands:
|
lukecwik
approved these changes
Dec 12, 2022
...ud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java
Outdated
Show resolved
Hide resolved
…am/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java
|
remind me after tests pass |
|
Ok - I'll remind @lukecwik after tests pass |
lukecwik
approved these changes
Dec 12, 2022
...ud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java
Outdated
Show resolved
Hide resolved
...latform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProtoTest.java
Outdated
Show resolved
Hide resolved
...latform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProtoTest.java
Outdated
Show resolved
Hide resolved
Apply spotless
|
retest this please |
lukecwik
reviewed
Dec 12, 2022
...ud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java
Outdated
Show resolved
Hide resolved
…am/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java
lostluck
pushed a commit
to lostluck/beam
that referenced
this pull request
Dec 22, 2022
…pache#24366) * Improve Integer conversion in BigQueryIO's Storage Write API method. * Improve Integer conversion in BigQueryIO's Storage Write API method. Introduced a dedicated Exception. Improved error messages by capturing the source failure and reducing message sizes. * Improve Integer conversion in BigQueryIO's Storage Write API method. Introduced a dedicated Exception; improved error messages by capturing the source failure. * Fixed a minor typo. * Merged PR with new commits. * Update sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java * Apply suggestions from code review Apply spotless * Update sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java Co-authored-by: slilichenko <Sergei Lilichenko> Co-authored-by: Lukasz Cwik <lcwik@google.com>
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling when converting TableRows to a schema containing BigQuery's INTEGER type: