Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Trying out property-based tests for Beam python coders (#22233)" #23265

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Sep 15, 2022

This reverts commit 9be9a43.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@pabloem
Copy link
Member Author

pabloem commented Sep 15, 2022

r: @Abacn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #23265 (2a34d0c) into master (30a48f0) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #23265      +/-   ##
==========================================
- Coverage   73.60%   73.58%   -0.02%     
==========================================
  Files         716      716              
  Lines       95334    95334              
==========================================
- Hits        70171    70156      -15     
- Misses      23867    23882      +15     
  Partials     1296     1296              
Flag Coverage Δ
python 83.40% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...ks/python/apache_beam/runners/worker/data_plane.py 87.57% <0.00%> (-1.70%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.09% <0.00%> (-0.48%) ⬇️
sdks/python/apache_beam/runners/common.py 88.59% <0.00%> (-0.25%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (ø)
sdks/python/apache_beam/transforms/combiners.py 93.43% <0.00%> (+0.38%) ⬆️
sdks/python/apache_beam/internal/metrics/metric.py 94.00% <0.00%> (+1.00%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 97.56% <0.00%> (+2.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pabloem
Copy link
Member Author

pabloem commented Sep 15, 2022

r: @kennknowles

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pabloem pabloem merged commit cb5230a into apache:master Sep 19, 2022
@pabloem pabloem deleted the rv-pbt branch September 19, 2022 17:07
@TheNeuralBit
Copy link
Member

Were these tests broken?

pabloem added a commit to pabloem/beam that referenced this pull request Sep 29, 2022
This reverts commit cb5230a, reversing
changes made to 485b943.
pabloem added a commit that referenced this pull request Oct 10, 2022
* Revert "Merge pull request #23265 from pabloem/rv-pbt"

This reverts commit cb5230a, reversing
changes made to 485b943.

* fixed issues with property-based test for coders

* Catch all keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants